Closed
Conversation
Adds wording that makes it clear that usually, replacing `std::endl` with `'\n'` is a good idea, but that there are rare cases, for instance when using `std::cout`, where flushing is important. An example of that encountered in practice that caused a bug when changing from `std::endl` to `'\n'` (not mentioned in the commit changes) is: Flushing `std::cout` (or some other stream that does not always automatically in all configurations flush upon `\n`), as part of checking assumptions and printing the results of checking, just before potentially crashing.
Contributor
|
Editors call: Thanks! We've reviewed your suggestion and we understand the nuance, but we think the current wording covers what we want to say here as simply as possible. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds wording that makes it clear that usually, replacing
std::endlwith'\n'is a good idea, but that there are rare cases, for instance when usingstd::cout, where flushing is important.An example of that encountered in practice that caused a bug when changing from
std::endlto'\n'(not mentioned in the commit changes) is:Flushing
std::cout(or some other stream that does not always automatically in all configurations flush upon\n), as part of checking assumptions and printing the results of checking, just before potentially crashing.